Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 11, 2023

Bumps pyvista from 0.36.1 to 0.41.1.

Release notes

Sourced from pyvista's releases.

v0.40.0

This release is marked by dramatic improvements to PyVista's Trame-powered Jupyter backend, default theming, picking capabilities, and significant maintenance to improve PyVista's long-term sustainability.

What's Changed

Breaking Changes

New Features

Bug fixes or behavior changes

Documentation

Maintenance

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [pyvista](https://github.com/pyvista/pyvista) from 0.36.1 to 0.41.1.
- [Release notes](https://github.com/pyvista/pyvista/releases)
- [Commits](pyvista/pyvista@v0.36.1...v0.41.1)

---
updated-dependencies:
- dependency-name: pyvista
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Related to package requirements maintenance Repository structure maintenance labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1116 (0f80c62) into master (19ae597) will decrease coverage by 1.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   87.46%   86.21%   -1.25%     
==========================================
  Files          81       81              
  Lines        9204     9197       -7     
==========================================
- Hits         8050     7929     -121     
- Misses       1154     1268     +114     

@PProfizi
Copy link
Contributor

image

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2023

A newer version of pyvista exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@PProfizi
Copy link
Contributor

Hi @AlejandroFernandezLuces, would you happen to have an idea of what could possibly be the issue here with the scalar bars? I haven't been able to bump PyVista since 0.36.1 due to this issue shown above.
I have never been able to reproduce locally despite pip freeze and pip installing the same venv packages used in the CI.
Have you ever seen something similar?

@AlejandroFernandezLuces

This is just happening when you are not using visual mode right? My bet is that there is some issue with how PyVista gets the screenshots when it is not in visual mode. We've seen issues that only happen in CI in PyMAPDL. I raised the PyMAPDL issues to Kitware, I'll add this one for them to check it.

If you need to upgrade PyVista and you are being hold by the documentation (and if only few examples are bad) you can temporarily generate the images for those examples and substitute them in the docs. But the best course is to wait for this to be reviewed by Kitware to see if they can tell us what is happening.

@PProfizi
Copy link
Contributor

PProfizi commented Sep 18, 2023

@AlejandroFernandezLuces I guess you could say it only happens when not in visual mode, yet I have generated the doc locally (so not in visual mode) and still could not reproduce.
Thanks for checking with Kitware.
My strategy until now has been to not bump PyVista on the requirements_docs.txt file but to not block it either in our pyproject.toml so people can still get the latest when installing. This is definitely not a perfect solution, hence my request today as this is a thorn I feel I won't be able to remove on my own.

@AlejandroFernandezLuces

@AlejandroFernandezLuces I guess you could say it only happens when not in visual mode, yet I have generated the doc locally (so not in visual mode) and still could not reproduce. Thanks for checking with Kitware. My strategy until now has been to not bump PyVista on the requirements_docs.txt file but to not block it either in our pyproject.toml so people can still get the latest when installing. This is definitely not a perfect solution, hence my request today as this is a thorn I feel I won't be able to remove on my own.

I understand your concerns, this is an issue I've been trying to tackle for a while with no success. The issue is now in Kitware hands, let's hope they are able to see what is happening: https://github.com/ansys-internal/kitware-ansys/issues/21

@PProfizi PProfizi changed the title Bump pyvista from 0.36.1 to 0.41.1 in /requirements Bump pyvista from 0.36.1 to 0.43.8 in /requirements May 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (ae7e203) to head (949badf).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   84.16%   85.35%   +1.19%     
==========================================
  Files          82       82              
  Lines        9655     9671      +16     
==========================================
+ Hits         8126     8255     +129     
+ Misses       1529     1416     -113     

Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing the issue with 0.43.8
image

@PProfizi PProfizi closed this Jun 21, 2024
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 21, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/requirements/pyvista-0.41.1 branch June 21, 2024 15:58
@PProfizi
Copy link
Contributor

Solved in #1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to package requirements maintenance Repository structure maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants