-
Notifications
You must be signed in to change notification settings - Fork 23
Bump pyvista from 0.36.1 to 0.43.8 in /requirements #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [pyvista](https://github.com/pyvista/pyvista) from 0.36.1 to 0.41.1. - [Release notes](https://github.com/pyvista/pyvista/releases) - [Commits](pyvista/pyvista@v0.36.1...v0.41.1) --- updated-dependencies: - dependency-name: pyvista dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
- Coverage 87.46% 86.21% -1.25%
==========================================
Files 81 81
Lines 9204 9197 -7
==========================================
- Hits 8050 7929 -121
- Misses 1154 1268 +114 |
|
A newer version of pyvista exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Hi @AlejandroFernandezLuces, would you happen to have an idea of what could possibly be the issue here with the scalar bars? I haven't been able to bump PyVista since 0.36.1 due to this issue shown above. |
|
This is just happening when you are not using visual mode right? My bet is that there is some issue with how PyVista gets the screenshots when it is not in visual mode. We've seen issues that only happen in CI in PyMAPDL. I raised the PyMAPDL issues to Kitware, I'll add this one for them to check it. If you need to upgrade PyVista and you are being hold by the documentation (and if only few examples are bad) you can temporarily generate the images for those examples and substitute them in the docs. But the best course is to wait for this to be reviewed by Kitware to see if they can tell us what is happening. |
|
@AlejandroFernandezLuces I guess you could say it only happens when not in visual mode, yet I have generated the doc locally (so not in visual mode) and still could not reproduce. |
I understand your concerns, this is an issue I've been trying to tackle for a while with no success. The issue is now in Kitware hands, let's hope they are able to see what is happening: https://github.com/ansys-internal/kitware-ansys/issues/21 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 84.16% 85.35% +1.19%
==========================================
Files 82 82
Lines 9655 9671 +16
==========================================
+ Hits 8126 8255 +129
+ Misses 1529 1416 -113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
Solved in #1626 |


Bumps pyvista from 0.36.1 to 0.41.1.
Release notes
Sourced from pyvista's releases.
... (truncated)
Commits
d09de76Update Trame (#4690)e6e5b3dBump version921efc4Docker improvements (#4686)c74cb56Release 0.41.06987ad2Change cell_type deprecation version908859dRelease 0.410399135Fix dynamic scraper paths (#4636)39a60b0Isolate plotting API (#4629)f5c4bd7Update contact/support information (#4669)b20dc69[pre-commit.ci] pre-commit autoupdate (#4666)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)